Merged
Conversation
…e proper environment variable usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker build and push workflow to improve its robustness and flexibility, especially in handling DockerHub credentials. The main changes ensure that the workflow can fall back to a default DockerHub username if the secret is not set, and introduce a new environment variable for organization.
Workflow improvements:
ORGset tofiledashto the workflow environment for potential future use.Credential handling and fallback logic:
imagesandrepositoryfields in the Docker metadata and publish steps to use${{ secrets.DOCKERHUB_USERNAME || 'testuser' }}. This provides a fallback to'testuser'if the DockerHub username secret is not set, improving workflow reliability. [1] [2]…e proper environment variable usage